Open
Conversation
kyra-patton
reviewed
Jun 1, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
✨💫 Nice work! I left some comments on time and space complexity. Let me know what questions you have.
🟢
|
|
||
|
|
||
| def heap_sort(list): | ||
| def heap_sort(l): |
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) where n is the length of self.store (??) | ||
| Space Complexity: O(1) |
There was a problem hiding this comment.
✨ Nice job on the time complexity, however space complexity would also be O(log n) because of the recursive call stack created by heap_up
| else: | ||
| return | ||
|
|
||
| def remove(self): |
| @@ -44,31 +120,13 @@ def __str__(self): | |||
|
|
|||
| def empty(self): | |||
|
|
||
| This could be **very** helpful for the add method. | ||
| Time complexity: O(log n) where n is the length of self.store (??) | ||
| Space complexity: O(1) |
There was a problem hiding this comment.
✨ However because of heap_up's recursive call, space complexity is O(log n).
|
|
||
| return removed.value | ||
|
|
||
| def heap_down(self, index): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?